Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions & build support for NTF #77

Merged

Conversation

nevelis
Copy link

@nevelis nevelis commented Jun 23, 2020

Small note on how to compile & activate NTF within OMEC.

@omecproject
Copy link

Can one of the admins verify this patch?

2 similar comments
@omecproject
Copy link

Can one of the admins verify this patch?

@omecproject
Copy link

Can one of the admins verify this patch?

ajamshed
ajamshed previously approved these changes Jun 23, 2020
Copy link
Member

@krsna1729 krsna1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wont go here. that will be the Makefile

INSTALL.md Show resolved Hide resolved
@yiannisy
Copy link

@krsna1729 do you want to have these instructions on the Makefile and spgwu as comments (instead of install.md)?

@krsna1729
Copy link
Member

@yiannisy the docker_setup.sh changes was what i was referring to be in Makefile. Since that is where the build happens. Something like this?

ENABLE_NTF               ?=

DOCKER_BUILD_ARGS        ?= --build-arg MAKEFLAGS=-j$(shell nproc) --build-arg CPU --build-arg BUILDKIT_INLINE_CACHE
DOCKER_BUILD_ARGS        += --build-arg ENABLE_NTF

user can run do

ENABLE_NTF=1 ./docker_setup.sh

or

make docker-build ENABLE_NTF=1

@yiannisy
Copy link

I don't have a build environment to try and test, so I will defer to @nevelis for this :)

@nevelis nevelis force-pushed the ntf-installation-instructions branch 2 times, most recently from d7cb7bf to 707f907 Compare July 7, 2020 18:04
install_ntf.sh Outdated Show resolved Hide resolved
@nevelis nevelis force-pushed the ntf-installation-instructions branch from 707f907 to 6af0f67 Compare July 7, 2020 19:24
INSTALL.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@nevelis nevelis force-pushed the ntf-installation-instructions branch 2 times, most recently from 43e7045 to 205d8a8 Compare July 8, 2020 03:15
krsna1729
krsna1729 previously approved these changes Jul 8, 2020
@krsna1729
Copy link
Member

retest this please

@nevelis
Copy link
Author

nevelis commented Jul 8, 2020

Hey @krsna1729 I committed your USE_NTF => ENABLE_NTF suggestion after your last review, any chance you could check it off? Thanks!

@krsna1729
Copy link
Member

@nevelis retest this please is the keyword for the jenkins CI :) Jenkins was down, blocking the merge

krsna1729
krsna1729 previously approved these changes Jul 8, 2020
@krsna1729
Copy link
Member

retest this please

@sindack
Copy link

sindack commented Jul 8, 2020

There were some inconsistencies with the CORD Jenkins - FOSSA Verification, so I retested this manually (to avoid retriggering everything again) and it passed, see: https://jenkins.opencord.org/job/omec_upf-epc_fossa/280/

sindack
sindack previously approved these changes Jul 8, 2020
@ajamshed
Copy link
Contributor

ajamshed commented Jul 8, 2020

Hi @nevelis. I am sorry... but can you please rebase? I will merge this PR today.

@nevelis nevelis dismissed stale reviews from sindack and krsna1729 via b599604 July 9, 2020 01:15
@nevelis nevelis force-pushed the ntf-installation-instructions branch from eef155b to b599604 Compare July 9, 2020 01:15
@nevelis
Copy link
Author

nevelis commented Jul 9, 2020

retest this please

1 similar comment
@krsna1729
Copy link
Member

retest this please

@krsna1729 krsna1729 merged commit f4ede57 into omec-project:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants