Small updates. #95
Merged
Small updates. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
krsna1729
reviewed
Jul 18, 2020
krsna1729
reviewed
Jul 18, 2020
krsna1729
reviewed
Jul 18, 2020
krsna1729
reviewed
Jul 18, 2020
krsna1729
reviewed
Jul 18, 2020
krsna1729
reviewed
Jul 18, 2020
|
Please address these too |
ajamshed
force-pushed
the
topics/misc_updates
branch
from
86ed7e6
to
250728e
Compare
|
retest this please |
krsna1729
reviewed
Jul 21, 2020
ajamshed
force-pushed
the
topics/misc_updates
branch
4 times, most recently
from
e929622
to
f2dfbed
Compare
krsna1729
reviewed
Jul 24, 2020
ajamshed
force-pushed
the
topics/misc_updates
branch
from
1572c9c
to
9db178d
Compare
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
krsna1729
reviewed
Jul 24, 2020
ajamshed
force-pushed
the
topics/misc_updates
branch
from
9db178d
to
479801a
Compare
Supressed prints in Counter module. Placed error checks for some function calls in pfcpiface controller. Moved UpdateFAR out of UpdateForwardingParameters scope. Added retrial logic with timeouts for GRPC calls. Removed useless function int2ip. Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
When all activity from SPGW-C/SMF stops (including heartbeat requests), delete all session records. Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
Separated out BESS specific GRPC calls from pfcpiface.go Separated out PFCP IE parsing from pfcpiface.go. Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
ajamshed
force-pushed
the
topics/misc_updates
branch
from
ce1fc49
to
93a4b2e
Compare
Make one common function for parsing UpdateFAR/CreateFAR. Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
ajamshed
force-pushed
the
topics/misc_updates
branch
from
93a4b2e
to
57cf247
Compare
Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
krsna1729
reviewed
Jul 28, 2020
krsna1729
reviewed
Jul 28, 2020
krsna1729
reviewed
Jul 28, 2020
ajamshed
force-pushed
the
topics/misc_updates
branch
from
69415d5
to
5d46c3d
Compare
krsna1729
previously approved these changes
Jul 28, 2020
A simple util function can be used to retrive sourceIP. Signed-off-by: Muhammad Asim Jamshed <muhammad.jamshed@intel.com>
ajamshed
force-pushed
the
topics/misc_updates
branch
from
5d46c3d
to
b2ef8c0
Compare
krsna1729
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supressed prints in Counter module.
Placed error checks for some function calls in pfcpiface controller.
Moved UpdateFAR out of UpdateForwardingParameters scope.
Added retrial logic with timeouts for GRPC calls.
Removed useless function int2ip.
Signed-off-by: Muhammad Asim Jamshed muhammad.jamshed@intel.com