Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Copy http2_util, logger_conf and logger_util to util project #21

Merged
merged 3 commits into from
May 29, 2024

Conversation

ghislainbourgeois
Copy link

Copy http2_util, logger_conf and logger_util to util project.

Once merged and released, dependent projects will be modified to remove the dependency on the previous small projects to simplify maintenance.

Copy link

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two minor edits/comments

http2_util/server.go Show resolved Hide resolved
http2_util/server_debug.go Show resolved Hide resolved
@gab-arrobo
Copy link

@ghislainbourgeois,
How different is this logger_util/log_level.go compared to the logger/logger_conf.go. To me, they look pretty similar. It looks like logger (content) is pretty much the same as logger_util, correct?

@gab-arrobo
Copy link

What about checking whether we can also add the util_3gpp into the util repo?

@ghislainbourgeois
Copy link
Author

@ghislainbourgeois, How different is this logger_util/log_level.go compared to the logger/logger_conf.go. To me, they look pretty similar. It looks like logger (content) is pretty much the same as logger_util, correct?

They look quite similar, I will try to make sure we can use only logger and get rid of logger_util completely.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghislainbourgeois,
Does not logger/logger.go already have similar content as this file? or am I overlooking something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files seem to be used in slightly different ways for different loggers. I am not comfortable moving this right now, and I think we should plan a logging cleanup as a separate task after we centralize those dependencies.

@gab-arrobo
Copy link

gab-arrobo commented May 29, 2024

@ghislainbourgeois, is this PR ready to merge? Or are you planning to address my previous comment about the logger/logger.go file/code?

@ghislainbourgeois
Copy link
Author

@ghislainbourgeois, is this PR ready to merge? Or are you planning to address my previous comment about the logger/logger.go file/code?

I have started looking in that previous comment, and evaluating if we can easily merge that code. I will let you know today what direction I choose.

@ghislainbourgeois
Copy link
Author

I think this is ready to merge now, and in the near future we should do a logging cleanup.

@gab-arrobo
Copy link

I think this is ready to merge now, and in the near future we should do a logging cleanup.

Ok, thanks. As soon as I merge it, I am going to create a new release/tag

Copy link

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit fdfe321 into omec-project:main May 29, 2024
9 checks passed
@gab-arrobo
Copy link

@ghislainbourgeois,
I just created release/tag v1.1.0 such that we can use it in the other repos. Please free to open PRs in the other repos to replace https2_util, logger_conf, logger_util and util_3gpp repo with this util v1.1.0 version

@ghislainbourgeois ghislainbourgeois deleted the add-small-utils branch May 30, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants