DeviceGroup, Subscribers Config Update changes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thakurajayL
reviewed
Sep 17, 2021
thakurajayL
reviewed
Sep 17, 2021
proto/server/clientEvtHandler.go
Outdated
| deleteConfigHss(client, val) | ||
| } | ||
| } | ||
|
|
||
| for _, imsi := range devGroup.Imsis { |
There was a problem hiding this comment.
We end up in adding all IMSI's again...
e.g.
if device group had IMSI1, IMSI2
Now if I remove IMSI2 from the group, then with new code we send delete IMSI2. and then we are sending IMSI1 addition again.
There was a problem hiding this comment.
yes, you are right. i add logic to get newly added imsi list also.
thakurajayL
reviewed
Sep 17, 2021
… into sdcore-458-dev
vthiruveedula
force-pushed
the
sdcore-458-dev
branch
from
e66ff25
to
7705a00
Compare
thakurajayL
reviewed
Sep 20, 2021
| @@ -19,7 +19,6 @@ import ( | |||
|
|
|||
| "github.com/free5gc/MongoDBLibrary" | |||
| mongoDBLibLogger "github.com/free5gc/MongoDBLibrary/logger" | |||
| //"github.com/free5gc/http2_util" | |||
thakurajayL
reviewed
Sep 20, 2021
| @@ -760,17 +760,24 @@ func DeleteSubscriberByID(c *gin.Context) { | |||
|
|
|||
| ueId := c.Param("ueId") | |||
|
|
|||
| filterUeIdOnly := bson.M{"ueId": ueId} | |||
There was a problem hiding this comment.
I thought this is already committed.
thakurajayL
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.