traffic class update for qci and arp #45
Conversation
badhrinathpa
force-pushed
the
traffic_class_upd
branch
from
788849c
to
5d14e87
Compare
| @@ -41,7 +41,7 @@ type SliceApplicationFilteringRules struct { | |||
|
|
|||
| AppMbrDownlink int32 `json:"app-mbr-downlink,omitempty"` | |||
|
|
|||
| TrafficClass string `json:"traffic-class,omitempty"` | |||
| TrafficClass *TrafficClassInfo `json:"traffic-class,omitempty"` | |||
There was a problem hiding this comment.
This will make it dependent on ROC. Do you know when they are fixing their part ? else calling new field as traffic-class-new would make it backward compatible ?
There was a problem hiding this comment.
this is new config. old roc doesn't send this.
| Pdb int32 `json:"pdb,omitempty"` | ||
|
|
||
| // Packet Error Loss Rate | ||
| Pelr int32 `json:"pelr,omitempty"` |
There was a problem hiding this comment.
Andy was saying this should be float. Using integer can you give some sample values how it would look like ?
There was a problem hiding this comment.
Is this something concern for UPF only ?
There was a problem hiding this comment.
this value isn't used yet.. will be used in future in upf. the configuration will be used as exponent value. so better to use as integer I think
| @@ -259,6 +259,20 @@ func fillDeviceGroup(groupName string, devGroupConfig *configmodels.DeviceGroups | |||
| ipdomain.UePool = devGroupConfig.IpDomainExpanded.UeIpPool | |||
| ipdomain.DnsPrimary = devGroupConfig.IpDomainExpanded.DnsPrimary | |||
| ipdomain.Mtu = devGroupConfig.IpDomainExpanded.Mtu | |||
| if devGroupConfig.IpDomainExpanded.UeDnnQos != nil { | |||
There was a problem hiding this comment.
if ue-dnn-qos is not available then can you please copy it from default qos mentioned at slice ?
badhrinathpa
force-pushed
the
traffic_class_upd
branch
from
5d14e87
to
a4c87e2
Compare
Update traffic class from string to structure containing qci, arp, packet delay budget and Packet error loss rate