Spurious IMSI delete from configpod #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thakurajayL
commented
Oct 29, 2021
thakurajayL
commented
| @@ -241,7 +241,7 @@ func NetworkSlicePostHandler(c *gin.Context, msgOp int) bool { | |||
|
|
|||
| var msg configmodels.ConfigMessage | |||
| msg.MsgMethod = msgOp | |||
| msg.SliceName = sliceName | |||
| procReq.SliceName = sliceName | |||
| msg.MsgType = configmodels.Network_slice | |||
| msg.Slice = &procReq | |||
| msg.SliceName = sliceName | |||
There was a problem hiding this comment.
we have to set slicename in configMessage object because we are referring it to take copy of lastSlice snapshot
There was a problem hiding this comment.
same comment for devgroup too
IMSIs were deleted from HSS & re-added. Due to groupName not initialized in the DeviceGroupMessage
thakurajayL
force-pushed
the
dev-1.5.2/config-imsi-delete1
branch
from
7244e2b
to
8f45e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.