Adds subscribers to Am data collection when they are created. #84
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Please take a look, if it seems good I will put it to ready to review @ghislainbourgeois :) |
configapi/api_sub_config.go
Outdated
| ueId := amData["ueId"].(string) // Since ueId is guaranteed to exist | ||
|
|
||
| var tmp configmodels.SubsListIE | ||
| tmp.UeId = ueId |
There was a problem hiding this comment.
| ueId := amData["ueId"].(string) // Since ueId is guaranteed to exist | |
| var tmp configmodels.SubsListIE | |
| tmp.UeId = ueId | |
| tmp := configmodels.SubsListIE{ | |
| UeId: amData["ueID"].(string), | |
| } |
Applies patches from the following PRs: omec-project/webconsole#83 omec-project/webconsole#84 omec-project/webconsole#86
configapi/api_sub_config.go
Outdated
| tmp := configmodels.SubsListIE{ | ||
| PlmnID: servingPlmnId.(string), | ||
| UeId: ueId.(string), | ||
| UeId: amData["ueID"].(string), |
There was a problem hiding this comment.
| UeId: amData["ueID"].(string), | |
| UeId: amData["ueId"].(string), |
saltiyazan
force-pushed
the
TELCO-789-adds-subs-to-db-when-posted
branch
from
9aea52a
to
8ea3eff
Compare
|
@saltiyazan please rebase this PR |
Adds subscriber to the database after it is created
The function returns subscribers without plmnid
saltiyazan
force-pushed
the
TELCO-789-adds-subs-to-db-when-posted
branch
from
8ea3eff
to
e6e7b46
Compare
Just did. |
Hi @saltiyazan, it is not. You need to align it with the master branch and that is why GitHub is showing
|
Hi @gab-arrobo |
|
test this please |
Improves test, renames variable to ueId and uses a realistic ueId value
|
ok to test |
|
Could you please rebase your branch, |
To be able to get subscribers created using
PostSubscriberByIDand making the behavior ofGetSubscriberssymmetric to it, we are adding a subscriber entry to thesubscriptionData.provisionedData.amDatacollection. At the time of the creation of the subscriber only theimsiis known and is added in theueIdfield, the rest of the fields are updated later on.