Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows #17

Merged
merged 29 commits into from Aug 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6971586
Add auto header 1
phrdang Aug 7, 2020
68ebe38
Merge branch 'master' of https://github.com/omega9656/learn-code into…
phrdang Aug 8, 2020
4d3b5cb
Remove push event
phrdang Aug 8, 2020
deaec27
Move config files to root
phrdang Aug 8, 2020
85191fa
Change html5 validator output to JSON
phrdang Aug 8, 2020
de6cb0e
Bot: Prettified code!
phrdang Aug 8, 2020
ac6a260
Revert html5 validator output format to default
phrdang Aug 8, 2020
23e078e
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
5d5df82
Bot: Prettified code!
phrdang Aug 8, 2020
98dc0ac
Add step to install stylelint sass config
phrdang Aug 8, 2020
a2aa4d0
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
04e985b
Bot: Prettified code!
phrdang Aug 8, 2020
0c9a5e3
Fix code style issues with stylelint
lint-action Aug 8, 2020
f814a96
Add stylelintignore to ignore javadoc dir
phrdang Aug 8, 2020
6d84647
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
3a2abdf
Bot: Prettified code!
phrdang Aug 8, 2020
327773a
Fix code style issues with stylelint
lint-action Aug 8, 2020
8eb2e93
Move stylelintignore to root
phrdang Aug 8, 2020
16c8d7c
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
16990ae
Bot: Prettified code!
phrdang Aug 8, 2020
721492a
Fix code style issues with stylelint
lint-action Aug 8, 2020
59103ba
Fix stylelint error (black --> #000000)
phrdang Aug 8, 2020
1b5f79f
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
9e35367
Bot: Prettified code!
phrdang Aug 8, 2020
fc1f4ca
Fix code style issues with stylelint
lint-action Aug 8, 2020
d104506
Add HTML5 validator parser
phrdang Aug 8, 2020
f19fdb4
Merge branch 'fix-workflows' of https://github.com/omega9656/learn-co…
phrdang Aug 8, 2020
f58169f
Bot: Prettified code!
phrdang Aug 8, 2020
d106d2f
Fix code style issues with stylelint
lint-action Aug 8, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/main.yml
Expand Up @@ -8,8 +8,6 @@ name: Continuous Integration
on:
pull_request:
branches: [ master ]
push:
branches: [ master ]

jobs:
### Format Java ###
Expand All @@ -31,7 +29,7 @@ jobs:
- name: Prettify Java code
uses: lwerner-lshigh/prettier_action_java@v1.1.1
with:
prettier_options: --write **/*.java --config config/.prettierrc.json
prettier_options: --write **/*.java
branch: ${{ github.head_ref }}
commit_message: 'Bot: Prettified Java code!'
env:
Expand All @@ -57,7 +55,7 @@ jobs:
# reporter: github-pr-review

# this doesn't work yet: https://github.com/nikitasavinov/checkstyle-action/issues/10
# checkstyle_config: config/google_checks_mod.xml
# checkstyle_config: google_checks_mod.xml

################ Format ###################
### HTML, CSS, SCSS, JS, JSON, MD, YAML ###
Expand All @@ -77,9 +75,7 @@ jobs:
### Prettier Options ###
# --write prettifies directory/file given
# in this case, everything is prettified (if supported)
# --ignore-path is the path to the .prettierignore file
# (default is ./.prettierignore)
prettier_options: --write . --config config/.prettierrc.json
prettier_options: --write .
commit_message: 'Bot: Prettified code!'

### Lint CSS, SCSS ###
Expand All @@ -91,14 +87,17 @@ jobs:
- name: Check out Git repository
uses: actions/checkout@v2

- name: Install stylelint-config-sass-guidelines
run: npm install --save stylelint-config-sass-guidelines

- name: Install stylelint
run: npm install --save-dev stylelint stylelint-config-standard

- name: Run stylelint
uses: samuelmeuli/lint-action@v1
with:
github_token: ${{ secrets.github_token }}
stylelint: true # Enables stylelint on Lint Action
stylelint: true # Enables stylelint on Lint Action
auto_fix: true # Enables auto fix (Lint Action will auto commit)

### Lint HTML ###
Expand Down
File renamed without changes.
1 change: 1 addition & 0 deletions .stylelintignore
@@ -0,0 +1 @@
javadoc/
File renamed without changes.
2 changes: 2 additions & 0 deletions docs/_layouts/unit-content.html
Expand Up @@ -2,6 +2,8 @@
layout: default
---

<h1>{{ page.parent }}: {{ page.title }}</h1>

{{ content }}

{% include next-prev.html %}
1 change: 1 addition & 0 deletions docs/_sass/color_schemes/omega.scss
Expand Up @@ -19,5 +19,6 @@ $sidebar-color: $cardinal-000;
// Custom button
.btn-cardinal {
@include btn-color($white, $cardinal-300);

color: $white !important;
}
10 changes: 5 additions & 5 deletions docs/_sass/custom/custom.scss
Expand Up @@ -3,12 +3,12 @@
// can add custom CSS

// Google Fonts
@import url("https://fonts.googleapis.com/css2?family=Oswald:wght@200;300;400;500;600;700&family=Oxygen:wght@300;400;700&family=Raleway:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap");
@import url('https://fonts.googleapis.com/css2?family=Oswald:wght@200;300;400;500;600;700&family=Oxygen:wght@300;400;700&family=Raleway:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap');

// Typography
$oxygen: "Oxygen", sans-serif;
$oswald: "Oswald", sans-serif;
$raleway: "Raleway", sans-serif;
$oxygen: 'Oxygen', sans-serif;
$oswald: 'Oswald', sans-serif;
$raleway: 'Raleway', sans-serif;

body {
font-family: $oxygen;
Expand All @@ -35,7 +35,7 @@ h6 {
}

.uml {
border: 1px solid black;
border: 1px solid #000;
border-collapse: collapse;
}

Expand Down
File renamed without changes.
Binary file added html5-validator/error-output.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions html5-validator/errors.txt
@@ -0,0 +1 @@
ERROR:html5validator.validator:['"file:/github/workspace/./docs/blog.html":1.1-9.1: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/blog.html":1.1-9.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/blog.html":10.1-10.7: error: Element "style" not allowed as child of element "body" in this context. (Suppressing further errors from this subtree.)', '"file:/github/workspace/./docs/blog.html":18.5-20.4: error: Text not allowed in element "ul" in this context.', '"file:/github/workspace/./docs/blog.html":21.13-21.52: error: Bad value "{{ post.url | relative_url }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/blog.html":26.10-27.17: error: Text not allowed in element "ul" in this context.', '"file:/github/workspace/./docs/404.html":1.1-8.1: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/404.html":1.1-8.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/categories.html":1.1-8.1: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/categories.html":1.1-8.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/categories.html":15.9-15.49: error: Bad value "#{{ category_name | slugize }}" for attribute "id" on element "div": An ID must not contain whitespace.', '"file:/github/workspace/./docs/categories.html":19.9-19.48: error: Bad value "{{ category_name | slugize }}" for attribute "name" on element "a": An ID must not contain whitespace.', '"file:/github/workspace/./docs/categories.html":22.13-22.16: error: Element "li" not allowed as child of element "article" in this context. (Suppressing further errors from this subtree.)', '"file:/github/workspace/./docs/_layouts/quiz.html":1.1-4.1: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_layouts/quiz.html":1.1-4.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_layouts/post.html":1.1-4.1: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_layouts/post.html":1.1-4.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_layouts/post.html":5.1-5.7: error: Element "style" not allowed as child of element "body" in this context. (Suppressing further errors from this subtree.)', '"file:/github/workspace/./docs/_layouts/unit-content.html":1.1-7.28: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_layouts/unit-content.html":1.1-7.28: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_layouts/unit.html":1.1-5.47: error: Non-space characters found without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_layouts/unit.html":1.1-5.47: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/next-prev-unit.html":1.1-1.7: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/next-prev-unit.html":19.25-22.1: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/next-prev-unit.html":25.5-28.9: error: Bad value "/learn-code/learn/unit{{ prev_unit }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/next-prev-unit.html":30.33-30.34: error: Bad character "=" after "<". Probable cause: Unescaped "<". Try escaping it as "&lt;".', '"file:/github/workspace/./docs/_includes/next-prev-unit.html":31.5-34.9: error: Bad value "/learn-code/learn/unit{{ next_unit }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/contributors.html":1.1-1.28: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/contributors.html":1.1-1.28: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/contributors.html":1.29-3.4: error: Text not allowed in element "ul" in this context.', '"file:/github/workspace/./docs/_includes/contributors.html":4.9-5.13: error: Bad value "{{ contributor.html_url }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/contributors.html":5.14-10.10: error: Bad value "{{ contributor.avatar_url }}" for attribute "src" on element "img": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/contributors.html":11.10-12.17: error: Text not allowed in element "ul" in this context.', '"file:/github/workspace/./docs/_includes/next-prev.html":7.25-8.60: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/next-prev.html":7.25-8.60: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/next-prev.html":17.5-17.44: error: Bad value "{{ node.url | absolute_url }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/next-prev.html":21.5-21.44: error: Bad value "{{ node.url | absolute_url }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/categories.html":1.1-1.29: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/categories.html":1.1-1.29: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/categories.html":4.5-5.9: error: Bad value "{{ site.baseurl }}/categories/#{{ category | slugize }}" for attribute "href" on element "a": Illegal character in path segment: "{" is not allowed.', '"file:/github/workspace/./docs/_includes/uml/human2.html":1.1-1.19: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/uml/human2.html":1.1-1.19: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/uml/human3.html":1.1-1.19: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/uml/human3.html":1.1-1.19: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/uml/human1.html":1.1-1.19: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/uml/human1.html":1.1-1.19: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-9.html":1.1-1.3: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-9.html":1.1-1.3: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-11.html":1.1-1.3: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-11.html":1.1-1.3: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-3.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-5.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-1.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-2.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-8.html":1.1-1.3: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-8.html":1.1-1.3: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-7.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-6.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./docs/_includes/quizzes/unit-10.html":1.1-1.3: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-10.html":1.1-1.3: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":1.1-9.5: error: Start tag seen without seeing a doctype first. Expected "<!DOCTYPE html>".', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":1.1-9.5: error: Element "head" is missing a required instance of child element "title".', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":1.1-9.5: error: The "frameborder" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":1.1-9.5: error: The "marginheight" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":1.1-9.5: error: The "marginwidth" attribute on the "iframe" element is obsolete. Use CSS instead.', '"file:/github/workspace/./docs/_includes/quizzes/unit-4.html":9.6-9.13: error: Text not allowed in element "iframe" in this context.', '"file:/github/workspace/./javadoc/overview-summary.html":13.13-13.64: error: Bad value "0;index.html" for attribute "content" on element "meta": Expected a space character, but saw "i" instead.']