[BUGS#1247] fix: filters4: create event reader when entering event mode #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Complete solution to avoid StaX implementation difference. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- AbstractXmlFilter: variable name, case-default - OpenXmlFilter: variable name, suppression update Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This was referenced Feb 6, 2024
|
#947 back-port the improvement here into 6.0 branch. |
miurahr
deleted the
topic/miurahr/filters4/fix-event-reader-difference-impl
branch
chelobaka
pushed a commit
to chelobaka/omegat
that referenced
this pull request
Feb 10, 2024
…de (omegat-org#945) * [BUGS#1247] fix: filters4: create event reader when entering event mode - Complete solution to avoid StaX implementation difference. Signed-off-by: Hiroshi Miura <miurahr@linux.com> * style: improve filters4 styles - AbstractXmlFilter: variable name, case-default - OpenXmlFilter: variable name, suppression update Signed-off-by: Hiroshi Miura <miurahr@linux.com> --------- Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information
#937