refactor: markers: avoid unnecessary static #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need unit tests for these markers |
There are unnecessary static variable initialization and static functions. These break registering Markers as plugins. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/marker/avoid-static-initialization
branch
from
332b97d
to
db82709
Compare
chelobaka
pushed a commit
to chelobaka/omegat
that referenced
this pull request
Feb 10, 2024
* refactor: markers: avoid unnecessary static There are unnecessary static variable initialization and static functions. These break registering Markers as plugins. Signed-off-by: Hiroshi Miura <miurahr@linux.com> * refactor: initialize fields in constructor Signed-off-by: Hiroshi Miura <miurahr@linux.com> --------- Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are unnecessary static variable initialization and static functions. These break registering Markers as plugins.
Pull request type
refactor
Which ticket is resolved?
What does this PR change?
Stylesstatic reference in static initialization, because the reference should be happened after theme modules initialization.Other information
Bring improvements from #951