refactor: whitespace marker to be with single class #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces a number of threads and may improve performance. It also help make WhitespaceMarkers to be implemented as plugins. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
commented
Feb 9, 2024
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
❌ Run Gradle test failed: |
1 similar comment
|
❌ Run Gradle test failed: |
- Fix wrong status check - mark when segment is not active Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Fix wrong status check - mark when segment is not active Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
chelobaka
pushed a commit
to chelobaka/omegat
that referenced
this pull request
Feb 10, 2024
* refactor: whitespace marker to be single method This reduces a number of threads and may improve performance. It also help make WhitespaceMarkers to be implemented as plugins. Signed-off-by: Hiroshi Miura <miurahr@linux.com> * feat: register WhitespaceMarker as plugin Signed-off-by: Hiroshi Miura <miurahr@linux.com> * feat: WhitespaceMarker unit test Signed-off-by: Hiroshi Miura <miurahr@linux.com> * fix: typo Signed-off-by: Hiroshi Miura <miurahr@linux.com> * feat: improve BiDi marker unit test Signed-off-by: Hiroshi Miura <miurahr@linux.com> * fix: spotbugs errors Signed-off-by: Hiroshi Miura <miurahr@linux.com> * style: copyright header Signed-off-by: Hiroshi Miura <miurahr@linux.com> * fix: condition bugs - Fix wrong status check - mark when segment is not active Signed-off-by: Hiroshi Miura <miurahr@linux.com> * fix: condition bugs - Fix wrong status check - mark when segment is not active Signed-off-by: Hiroshi Miura <miurahr@linux.com> * refactor: improve test assertion Signed-off-by: Hiroshi Miura <miurahr@linux.com> * chore: update copyright holder Signed-off-by: Hiroshi Miura <miurahr@linux.com> --------- Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces a number of threads and may improve performance. It also help make WhitespaceMarkers to be implemented as plugins.
Pull request type
refactor
Which ticket is resolved?
What does this PR change?
Other information
Brings from #951