-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add and improve maker unit tests #955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Extend IEditor to have isOrientationAllLtr method to test the marker Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Run Gradle test failed: |
- Extend MarkerTestBase to allow extend mock project configuration Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- fix visibility of internal class Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
RemoveTagMarkerTest does not change preference Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
chelobaka
pushed a commit
to chelobaka/omegat
that referenced
this pull request
Feb 10, 2024
* refactor: fix marker test package and classname Signed-off-by: Hiroshi Miura <miurahr@linux.com> * chore: add ComesFromAutoTMMarkerTest test Signed-off-by: Hiroshi Miura <miurahr@linux.com> * chore: improve marker tests Signed-off-by: Hiroshi Miura <miurahr@linux.com> * feat: add ProtectedPartsMarker test - Extend IEditor to have isOrientationAllLtr method to test the marker Signed-off-by: Hiroshi Miura <miurahr@linux.com> * feat: add ReplaceMarkerTest - Extend MarkerTestBase to allow extend mock project configuration Signed-off-by: Hiroshi Miura <miurahr@linux.com> * refactor: ReplaceMarkerTest Signed-off-by: Hiroshi Miura <miurahr@linux.com> * style: ReplaceMarkerTest - fix visibility of internal class Signed-off-by: Hiroshi Miura <miurahr@linux.com> * style: IEditor Signed-off-by: Hiroshi Miura <miurahr@linux.com> * fix: avoid interference among tests RemoveTagMarkerTest does not change preference Signed-off-by: Hiroshi Miura <miurahr@linux.com> * chore: update jacoco target packages Signed-off-by: Hiroshi Miura <miurahr@linux.com> --------- Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
refactor
Which ticket is resolved?
What does this PR change?
Other information