Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add and improve maker unit tests #955

Merged
merged 10 commits into from
Feb 10, 2024

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Feb 9, 2024

Pull request type

  • Other (describe below)
    refactor

Which ticket is resolved?

What does this PR change?

Other information

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Extend IEditor to have isOrientationAllLtr method to test the marker

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

❌ Run Gradle test failed:

- Extend MarkerTestBase to allow extend mock project configuration

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- fix visibility of internal class

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@omegat-org omegat-org deleted a comment from github-actions bot Feb 10, 2024
RemoveTagMarkerTest does not change preference

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@omegat-org omegat-org deleted a comment from github-actions bot Feb 10, 2024
@omegat-org omegat-org deleted a comment from github-actions bot Feb 10, 2024
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr merged commit f32ff02 into master Feb 10, 2024
9 checks passed
@miurahr miurahr deleted the topic/miurahr/marker/add-unit-tests branch February 10, 2024 04:49
chelobaka pushed a commit to chelobaka/omegat that referenced this pull request Feb 10, 2024
* refactor: fix marker test package and classname

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* chore: add ComesFromAutoTMMarkerTest test

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* chore: improve marker tests

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* feat: add ProtectedPartsMarker test

- Extend IEditor to have isOrientationAllLtr method to test the marker

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* feat: add ReplaceMarkerTest

- Extend MarkerTestBase to allow extend mock project configuration

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* refactor: ReplaceMarkerTest

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* style: ReplaceMarkerTest

- fix visibility of internal class

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* style: IEditor

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* fix: avoid interference among tests

RemoveTagMarkerTest does not change preference

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

* chore: update jacoco target packages

Signed-off-by: Hiroshi Miura <miurahr@linux.com>

---------

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant