Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively add files and directories #16

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Recursively add files and directories #16

merged 1 commit into from
Jan 13, 2020

Conversation

tslocum
Copy link
Contributor

@tslocum tslocum commented Dec 14, 2019

No description provided.

@tslocum
Copy link
Contributor Author

tslocum commented Jan 3, 2020

I'm glad to update this if there is any feedback.

@omeid
Copy link
Owner

omeid commented Jan 8, 2020

Sorry for the late reply Trevor, I am looking into this right now and will get back to you very soon.

omeid
omeid requested changes Jan 8, 2020
View reviewed changes
Copy link
Owner

@omeid omeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you please add tests? :)

resources.go Show resolved Hide resolved
@tslocum
Copy link
Contributor Author

tslocum commented Jan 9, 2020

Will you please explain what the tests you're requesting would look like?

@tslocum
Copy link
Contributor Author

tslocum commented Jan 9, 2020

I realized what you meant and have added test cases, and made this a non-breaking change.

@omeid omeid merged commit eb442c9 into omeid:master Jan 13, 2020
@omeid
Copy link
Owner

omeid commented Jan 13, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omeid omeid omeid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tslocum @omeid