Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to terms of service #67

Closed
jimsafley opened this issue Nov 18, 2020 · 2 comments
Closed

Improvements to terms of service #67

jimsafley opened this issue Nov 18, 2020 · 2 comments

Comments

@jimsafley
Copy link
Contributor

See this forum post.

There is interest in changing the terms of service (TOS) from a plain text to a HTML field. I forget why we decided to make TOS plain text, but it seems like a good idea. One reservation is how it would change existing TOS's that were written using unformatted text and new lines.

We'd do this by adding CKEditor JS to the site admin template:

CKEDITOR.inline(document.getElementById(collecting_tos'));

And changing the Content-Type in IndexController::tosAction():

$response->getHeaders()->addHeaderLine('Content-Type', 'text/html; charset=utf-8');
@jimsafley
Copy link
Contributor Author

Actually, the specific request is not to make the TOS a HTML field, but to have an option to change the TOS URL itself. This should be possible by adding a "Terms of service URL" field to site settings, and using that on the collecting form. I prefer this solution over the one above.

@jimsafley jimsafley changed the title Change TOS field from plain text to HTML Improvements to terms of service Nov 19, 2020
@jimsafley
Copy link
Contributor Author

Fixed in c5edc9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant