Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes v1.1.0 package installation failure & dep updates #36

Merged
merged 2 commits into from
Jul 9, 2021
Merged

fix: Fixes v1.1.0 package installation failure & dep updates #36

merged 2 commits into from
Jul 9, 2021

Conversation

iamjoeker
Copy link
Contributor

Description

  • Fixes package installation by moving the husky install from the postinstall to the prepare script (as recommended by husky docs).
  • Updates dependencies to address audit advisories to extent possible

Motivation and Context

How Has This Been Tested?

  • npm test all tests pass
  • linked to my local code base and verified build/test/run in development and production node environments (v14)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@iamjoeker iamjoeker requested a review from omermorad as a code owner July 9, 2021 03:30
@iamjoeker iamjoeker changed the title Fix v1.1.0 package installation failure & dep updates fix: Fixes v1.1.0 package installation failure & dep updates Jul 9, 2021
@omermorad omermorad merged commit 7302e9b into omermorad:master Jul 9, 2021
omermorad pushed a commit that referenced this pull request Jul 9, 2021
@semantic-release-bot
chore(release): 1.1.1 [skip ci]
a529236 
## [1.1.1](v1.1.0...v1.1.1) (2021-07-09)

### Bug Fixes

* Fixes v1.1.0 package installation failure & dep updates ([#36](#36)) ([7302e9b](7302e9b)), closes [#35](#35)
@iamjoeker iamjoeker deleted the fix/pkg-install-not-run-husky branch July 9, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omermorad omermorad omermorad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation of v1.1.0 failing due to husky call in postinstall script
2 participants
@iamjoeker @omermorad