-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compression = None
on line 193 of parse.py
#22
Comments
Thanks for the question. I'm pretty sure that this flag is irrelevant
because pandas can infer compression automatically (this code is taken
directly from ldsc, which was written ~6 years ago before pandas could do
this). Do you have an example where this flag is required? I just verified
that the code can work with .gzipped files on my system (using pandas
0.25.3, though support for compressed files existed for several years I
think).
…On Mon, Feb 17, 2020 at 3:47 PM David A Knowles ***@***.***> wrote:
Is this deliberate? It seems to mean you can't read compressed files since
it overrides the automatic compression detection.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22?email_source=notifications&email_token=ACNCB423V6DWL5EAGHMAKYTRDLZVTA5CNFSM4KWYIT32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOEILMA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNCB43DMXYSDGJLRWWIW6LRDLZVTANCNFSM4KWYIT3Q>
.
|
The problem is |
You're right, my bad --- my test was incorrect. I just pushed an updated
version that disables this line (I made sure that I can now read gzipped
ldscore files). Hope it's fine now!
…On Mon, Feb 17, 2020 at 7:35 PM David A Knowles ***@***.***> wrote:
The problem is compression = None gets passed to pandas which overrides
the auto compression-type detection (at least on my system). The compression
= "infer" is the default for pd.read_csv.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#22?email_source=notifications&email_token=ACNCB447SO5ZU3WKDGH3QL3RDMULXA5CNFSM4KWYIT32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMADBTY#issuecomment-587215055>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNCB4Z4GL3GZBSM5JK2IHDRDMULXANCNFSM4KWYIT3Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this deliberate? It seems to mean you can't read compressed files since it overrides the automatic compression detection.
The text was updated successfully, but these errors were encountered: