DMN-SCE retrofit #2 #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
dmn-sce-1
branch
5 times, most recently
from
c68817a
to
a7c99d3
Compare
|
This is now rebased on top of the recent changes. The DMN diagram does not validate due to SCEDI's required |
|
@falko to make the attribute |
Also note that sometimes the model element reference is not required in the existing specs, e.g. bpmn-miwg/bpmn-miwg-test-suite#897 |
Closed
falko
reviewed
Feb 2, 2024
Comment on lines
-92
to
-96
| <xsd:sequence> | ||
| <xsd:element name="FillColor" type="dc:Color" minOccurs="0" maxOccurs="1"/> | ||
| <xsd:element name="StrokeColor" type="dc:Color" minOccurs="0" maxOccurs="1"/> | ||
| <xsd:element name="FontColor" type="dc:Color" minOccurs="0" maxOccurs="1"/> | ||
| </xsd:sequence> |
There was a problem hiding this comment.
@barmac these have to stay for the namespace.
falko
reviewed
Feb 2, 2024
| <xsd:attribute name="fontBold" type="xsd:boolean"/> | ||
| <xsd:attribute name="fontUnderline" type="xsd:boolean"/> | ||
| <xsd:attribute name="fontStrikeThrough" type="xsd:boolean"/> | ||
| <xsd:attribute name="labelHorizontalAlignement" type="dc:AlignmentKind"/> |
There was a problem hiding this comment.
This has to stay because SCE fixed the typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the outcome of today's work on DMN-SCE retrofit.