httpService added try catch for error handling

omgitsjan · Apr 17, 2023 · 12531ec · 12531ec
1 parent a33a9a6
commit 12531ec
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/DiscordBot/Services/HttpService.cs b/DiscordBot/Services/HttpService.cs
@@ -33,8 +33,21 @@ public HttpService(IRestClient httpClient)
             request.AddJsonBody(JsonConvert.DeserializeObject(jsonBodyString) ?? "");
         }
 
+        var response = new RestResponse();
+
         // Send the HTTP request asynchronously and await the response.
-        var response = await _httpClient.ExecuteAsync(request);
+        try
+        {
+            response = await _httpClient.ExecuteAsync(request);
+        }
+        catch (Exception e)
+        {
+            response.IsSuccessStatusCode = false;
+            response.ErrorMessage = $"({nameof(GetResponseFromUrl)}): Unknown error occurred" + e.Message;
+            response.ErrorException = e;
+            response.StatusCode = System.Net.HttpStatusCode.InternalServerError;
+        }
+
         var content = response.Content;
 
         if (!response.IsSuccessStatusCode)

diff --git a/DiscordBot/Services/OpenWeatherMapService.cs b/DiscordBot/Services/OpenWeatherMapService.cs
@@ -31,8 +31,8 @@ public OpenWeatherMapService(IHttpService httpService, IConfiguration configurat
     public async Task<(bool Success, string Message, WeatherData? weatherData)> GetWeatherAsync(string city)
     {
         // Retrieve the url and the apikey from the configuration
-        _openWeatherMapUrl = _configuration["OpenWeatherMap:ApiKey"] ?? string.Empty;
-        _openWeatherMapApiKey = _configuration["OpenWeatherMap:ApiUrl"] ?? string.Empty;
+        _openWeatherMapUrl = _configuration["OpenWeatherMap:ApiUrl"] ?? string.Empty;
+        _openWeatherMapApiKey = _configuration["OpenWeatherMap:ApiKey"] ?? string.Empty;
 
         if (string.IsNullOrEmpty(_openWeatherMapApiKey) || string.IsNullOrEmpty(_openWeatherMapUrl))
         {