Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve drop length display & recording date/time #7

Merged
merged 5 commits into from Jun 11, 2021

Conversation

spikeheap
Copy link
Contributor

@spikeheap spikeheap commented Jun 11, 2021

This PR

  • formats the drop length with minutes & seconds
  • grabs the drop length when the media is loaded rather than on play
  • adds the recording timestamp
  • shifts the date/time formatting to the Vue component so we can use browser localisation

Screenshot 2021-06-11 at 10 59 37

This should resolve the following from #1:

  • Recording lengths not presented until played
  • Recording lengths not presented in a sensible format
  • Recording date doesn't show time

There's a momentary blip before the drop lengths are displayed because Howler needs to load the media. We could add some logic to show the drop only once it's been loaded.

Screen.Recording.2021-06-11.at.10.53.25.mov

@spikeheap spikeheap changed the title Ryan/timecodes ✨ Improve drop length display & recording date/time Jun 11, 2021
@omgmog omgmog merged commit 73cb378 into omgmog:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants