Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Behave should not collide with step names #72

Open
boolafish opened this issue Jul 14, 2018 · 1 comment
Open

Behave should not collide with step names #72

boolafish opened this issue Jul 14, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@boolafish
Copy link
Contributor

boolafish commented Jul 14, 2018

in our integration tests, there are several steps in different feature share the same name. eg. userA deposit 1 eth to plasma, userA transfers 1 eth to userB.

They should be using the same implementation. Currently there are multiple implementation for the same step name. However, behave framework does not ensures that which implementation it would take. see: behave/behave#496.
Though luckily it worked in our CI, but It breaks in my local env.

Here's my screenshot:
screen shot 2018-07-14 at 4 29 47 pm

You can see it is calling challenge_spent_coin_flow.feature:3 first but calling challenge_double_spending_flow.py:26 later.

@boolafish boolafish added the bug Something isn't working label Jul 14, 2018
@boolafish
Copy link
Contributor Author

Currently it is hard to re-use the integration step code because those hard coded block numbers that client need. if our CI does not break too much might worth wait a bit for #71. Or we can just re-name all steps in different features as a work-around now.

@boolafish boolafish added this to To do in plasma-cash phase1 Jul 16, 2018
@boolafish boolafish moved this from To do to Subtasked in plasma-cash phase1 Jul 17, 2018
@boolafish boolafish moved this from Subtasked to To do in plasma-cash phase1 Jul 17, 2018
@boolafish boolafish removed this from To do in plasma-cash phase1 Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant