Update ARIA attributes on ranges #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, wow! Thanks a lot for this contribution! I'll check it as far as I can! |
royeden
added a commit
to royeden/react-colorful
that referenced
this pull request
Jun 25, 2022
|
Tested it locally with VoiveOver and added a simple test for that. Everything works well. |
|
Thank you @omgovich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
In the
Huecomponent:aria-valuetexthas been changed toaria-valuenow. Since the "human understandable" value is numeric, we don't need bothvaluetextandvaluenow, andvaluenowis the "required" attributearia-valueminhas been set to 0 andaria-valuemaxhas been set to 360 to provide a bit more context for screen reader usersIn the
Alphacomponent:aria-valuenowhas been added. This is in addition toaria-valuetext. Screen readers will generally read out the more understandablevaluetext, butvaluenowis a required attribute to accompany itaria-valueminhas been set to 0 andaria-valuemaxhas been set to 100In the
Saturationcomponent:No change has been made! I don't believe there is an available numeric representation of the current value, so in this case I believe we can omit
aria-valuenowfor the time being until #152 is addressed.Snapshot tests have been updated to reflect the new attributes 馃檪
Check out the docs for
aria-valuenowfor more context