Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behaviour change in Version 4.0.1 #48

Closed
WolfWalter opened this issue Nov 12, 2021 · 2 comments · Fixed by #49
Closed

Unexpected behaviour change in Version 4.0.1 #48

WolfWalter opened this issue Nov 12, 2021 · 2 comments · Fixed by #49
Labels
bug

Comments

@WolfWalter
Copy link

WolfWalter commented Nov 12, 2021 •
edited

After upgrading to Version 4.0.1 the result of a version comparison changed. A change in behaviour was not mentioned in the changelog. Here is a example:
https://codepen.io/wolfwalter/pen/dyzqZNK

The result for compare('3.3.3','3.x.x','<') was false in 3.6.0 and is true in 4.0.1
@omichelsen omichelsen added the bug label Nov 12, 2021
@omichelsen
Copy link
Owner

Thanks for reporting, this is an oversight not covered by our unit tests. I will try and fix...

@omichelsen
Copy link
Owner

Made a PR #49 to fix. Comments are welcome, will merge soon.

@omichelsen omichelsen linked a pull request Nov 12, 2021 that will close this issue
fix(wildcard): should compare as equal to anything #49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wildcard): should compare as equal to anything omichelsen/compare-versions
2 participants
@omichelsen @WolfWalter