Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMI_physics_joint #147

Merged
merged 1 commit into from May 11, 2023
Merged

Conversation

aaronfranke
Copy link
Contributor

@aaronfranke aaronfranke commented Feb 23, 2023

Preview: https://github.com/aaronfranke/gltf-extensions/tree/OMI_physics_joint/extensions/2.0/OMI_physics_joint

This PR adds a new spec for physics joints.

Overall I like Microsoft's spec. This spec is similar with a few differences:

  • Joints are a separate spec instead of part of the rigid body spec.
  • Joints are their own nodes. This allows the joint's position to be defined by the transform of the glTF node it's on, which is much more intuitive. This is how Godot, Unreal, Roblox, and Blender work, but Unity has joints as part of a RigidBody node. It looks like Unity is the odd one out here, and Unity's way is less intuitive.
  • Some renames, min -> lowerLimit, max -> upperLimit, springConstant -> stiffness, springDamping -> damping.
  • It would also be good to continue discussing this list Questions about joints eoineoineoin/glTF_Physics#15

This PR includes a detailed spec, several example files, and a Godot Engine implementation with full support for import and export. The Godot implementation is in this ZIP: OMI_physics_joint.zip and here omigroup/omi-godot#1

Validator: omigroup/glTF-Validator#3

@aaronfranke aaronfranke changed the title [WIP] OMI_physics_joint OMI_physics_joint May 1, 2023
@aaronfranke aaronfranke marked this pull request as ready for review May 1, 2023 06:04
@aaronfranke aaronfranke force-pushed the OMI_physics_joint branch 3 times, most recently from ee91bbe to c2e7eaa Compare May 5, 2023 00:51
@robertlong
Copy link
Member

robertlong commented May 11, 2023

The vote passes to move to stage 1
Screenshot 2023-05-11 at 3 32 25 PM

@robertlong robertlong merged commit 2125091 into omigroup:main May 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants