OMI_physics_body: Add a center of mass property #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be nice to specify |
aaronfranke
force-pushed
the
center-of-mass
branch
from
8fd9f83
to
6990e58
Compare
aaronfranke
changed the title
|
Changed the PR to add a center of mass property instead of defining it as the origin. The default is |
5 in favor, 1 abstain
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had intended this to be the behavior, but I forgot to explicitly define it as such.Also change the wording near the start to only mention type and not mass, since we also have linearVelocity, angularVelocity, and inertiaTensor parameters not mentioned, so I don't think we need to mention mass.