Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OMI_audio_ogg_vorbis and OMI_audio_opus #221

Merged
merged 1 commit into from
May 31, 2024
Merged

OMI_audio_ogg_vorbis and OMI_audio_opus #221

merged 1 commit into from
May 31, 2024

Conversation

aaronfranke
Copy link
Contributor

These extensions extend KHR_audio_emitter with support for Ogg Vorbis audio data and Opus audio data, respectively.

I have not included any test files or example implementations for these.

@aaronfranke aaronfranke force-pushed the OMI_audio_o branch 2 times, most recently from ffa2636 to 259108e Compare May 24, 2024 02:03
antpb
antpb approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@antpb antpb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent changes look good. I cant see the diff but reading through the files changed still reads good to me and no edits.

update, nevermind found the diff. of course it read good on the second review, that wasnt a huge change 😆

@antpb antpb merged commit 683da97 into omigroup:main May 31, 2024
2 checks passed
@aaronfranke aaronfranke deleted the OMI_audio_o branch May 31, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antpb antpb antpb approved these changes

Assignees
No one assigned
Labels
new spec topic:audio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronfranke @antpb