Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we have DomStorage enable from WebView in AuthorizingPaymentActivity? #141

Closed
luongvo opened this issue Jul 29, 2020 · 3 comments
Closed

Comments

@luongvo
Copy link

luongvo commented Jul 29, 2020

Same to the question above, could we have DomStorage enable from WebView in AuthorizingPaymentActivity? Or can you provide a way to enable DomStorage on AuthorizingPaymentActivity's WebView via Intent data 🤔

The context is:

  • Our authorizing uri and its redirection mechanism require to use DOM storage feature.
  • Android Webview disables DOM storage by default.
  • OmiseSDK has a built-in webview to take care of authorizing payment flow and this webview disables DOM storage by default too, that leads to the error below:
2020-07-29 17:41:48.469 14598-14598/co.omise.gcpf.app.staging I/chromium: [INFO:CONSOLE(1154)] "Uncaught TypeError: Cannot read property 'removeItem' of null", source: webpack:///../deps/phoenix_live_view/priv/static/phoenix_live_view.js? (1154)

removeItem comes from a dom sessionStorage.
image

I'm not sure if there is any security concerns to enable DOM storage on AuthorizingPaymentActivity's WebView

domStorageEnabled = true
@nuxzero
Copy link
Contributor

nuxzero commented Jul 30, 2020

@luongvo Thank you for raised this issue. This seems like the JavaScript can't work without enable domStorageEnabled. Anyway, we are working on this issue. So, we will let you if there is an update. 🙂

@nuxzero
Copy link
Contributor

nuxzero commented Jul 30, 2020

@luongvo We just release the version 3.1.2 that included enabling Dom Storage on the WebView. Please update your application to the latest version and the error should be gone.

If you have any question that related to this issue please feel free to re-open this issue and ask your questions. 🙂

@nuxzero nuxzero closed this as completed Jul 30, 2020
@luongvo
Copy link
Author

luongvo commented Jul 30, 2020

@nuxzero great, I will give it a try, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants