Migrate OmiseSDK iOS to use Storyboard #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice kub 👍 |
|
👍 |
|
wait for conflicts fix. |
pitiphong-p
force-pushed
the
feature/storyboard
branch
from
f944d17
to
bd04248
Compare
Remove OMS prefix from CreditCardFormController
- Adopting Property Observer - Adopting more Swifty syntax and APIs
…roller in Storyboard
pitiphong-p
force-pushed
the
feature/storyboard
branch
from
bd04248
to
6f2d56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request migrates OmiseSDK's
CreditCardFormControllerUI to Storyboard instead of XIB based. Using Storyboard benefits us in some waysCreditCardFormControllerinstead of prototype based which will help us reduce some codes.CreditCardFormControllerin their app's storyboard by usingStoryboard Reference