Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Layer and Models Refactoring (v5) #273

Merged
merged 125 commits into from Mar 6, 2024
Merged

Network Layer and Models Refactoring (v5) #273

merged 125 commits into from Mar 6, 2024

Conversation

vault087
Copy link
Collaborator

  • Refactored Client to support unit testing and remove obsolete code
  • Refactored all data models, obsolete code was removed, comments added
  • Added unit tests for most public functions
  • Example App was modified to apply new changes

@vault087
Draft Client and URL requests implementation was added
f7ad7d6
@vault087
Add unsupported payment methods name to Capability.PaymentMethod
40fddbb
@vault087
Added properties to Capability and Payment Method.Added Banks to Capa…
0ae8d64 
…bility.PaymentMethod
@vault087
Added Token model
af562f4
@vault087
Refactor CountryInfo model and moved current country to OmiseSDK as a…
253f854 
… shared storage
@vault087
Implement observeChargeStatusUntilChange(tokenID: String)
0e16e60
@vault087
Implement createToken API request
f64cb97
@vault087
PaymentPayload was added
05a0246
@vault087
Refactor NetworkService and SourcePayments
dcef2bf
@vault087
Prepared new Source for Unit Testing
c10a74d
@vault087
Add Unit Tests for decoding SourceNew with list of simple sourceTypes
c2d97e1
@vault087
Refactor SourcePayload and adding comments for public properties
49f114a
@vault087
Adding comments to Source Type
c5f6678
@vault087
Namespece refactoring. Add unit tests for decoding Source
efc3b70
@vault087
Add comments to Source payloads
45a68ec
@vault087
Add DuitNowOBW source payment payload and unit tests
e419bc2
@vault087
Add Source json decoder and unit tests for Installment, Truemoney, Mo…
40d1ccc 
…bile Banking and Internet Banking
@vault087
Add econtext decode from Json and unit tests
c8e9d10
@vault087
Add unit tests for Source.Payment JSON encoding / decoding
ccce357
@vault087
Refactor namespaces and update unit tests
525d9f2
@vault087
Clean tests. Added Client unit tests
ebc6593
@vault087
Capability tests added
e59f348
@vault087
Remove old Data Layer and replaced with new one
9867b31
@vault087
Integrated new Data Model into Example App
3e58aac
@vault087
Refactor Source.Payload namings
3b19791
@vault087
Rearrange Project tree
1d286f0
@vault087
Cleanup warnings
f8e3240
@vault087
Cleanup warnings
76b2193
@vault087
Github action checkou@v2 was changed to checkout@v3
350df34
@vault087
Project tree rearrangements
be6cf00
@vault087
Arrange files locations
dea5a8d
@vault087
Update project settings to run ExampleApp from OmiseSDK. Add atome sc…
c96c807 
…reen
@vault087
Renamed CCVInfoPopupController
6f09d7b
@vault087
Moving Credit Card from Storyboard
046874b
@vault087
Credit Card ccv popup added
8e663ef
@vault087
Fix CreditCardController
3ca53a6
@vault087
New base controller for form type payment information screens
c0963b1
@vault087
AtomeController subclassed of PaymentFormBuilderController
25c4a81
@vault087
Define 2 base classes to build payment form view controllers
0109d3e
@vault087
PaymentFormController cleanup
9c546df
@vault087
PaymentInputsFormController base implementatino added
ae79927
@vault087
move econtext from storyboard to xib
b36a74d
@vault087
Add completion to payment details controllers
ccf64eb
@vault087
FPX payment is refactored
cddb1a1
@vault087
Storyboard clean up
cc44bd5
@vault087
DuitNowOBW Refactored
4c7ea9d
@vault087
truemoney wallet refactored
c1e11d7
@vault087
cleanup storyboard
9c7ae13
@vault087
merge
1c9919d
@vault087
Project tree cleanup
b384849
@vault087
Update eContext payment translations
ee6023a
@vault087
Move Credit card to OmiseSDK
4e9b2ff
@vault087
Move AuthorizingPaymentViewController.xib out of Storyboard
b1d51f6
@vault087
Cleanup example app Storyboard
9764e47
@vault087
Clean up warnings
d5056a8
@vault087
Changing Readme
7e9ddef
@vault087
Clean sonarcloud warning
4f77e62
@vault087
Merge pull request #275 from omise/feature/MIT-2251_v5_AdaptableTable…
10cd9e0 
…View

UI Layer refactoring
@vault087 vault087 merged commit a2b256d into feature/v5_refactoring Mar 6, 2024
2 checks passed
@vault087 vault087 deleted the feature/MIT-1554_v5 branch March 6, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danfowler danfowler danfowler approved these changes

@aashishgurung aashishgurung aashishgurung approved these changes

@AnasNaouchi AnasNaouchi AnasNaouchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vault087 @danfowler @aashishgurung @AnasNaouchi