Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release V5.0.0 #277

Merged
merged 237 commits into from Apr 4, 2024
Merged

Release V5.0.0 #277

merged 237 commits into from Apr 4, 2024

Conversation

vault087
Copy link
Collaborator

@vault087 vault087 commented Mar 6, 2024 •
edited

Omise SDK v5.0.0

  • Objective-C support was dropped
  • OmiseSDK class was introduced to provide public interface to work with SDK
  • Storyboard was removed and replaced with Xib files
  • Localization was updated and missing translations were added
  • Network layer was updated and public interface was move moved ClientProtocol
  • Data and UI layers were heavily refactored to provide clean and testable code

@vault087
Refactor OMSSourceTypeValue. Dropped Objc Prefix in Interface Builder…
187b3b6 
… class name field
@vault087
Merge OCBC changes
e3a5bdf
@vault087
Removing @objc marked and deprecated code
9881fa6
@vault087
Drop deprecated OMS prefix from SourceTypeValue enum
b33ae9c
@vault087
Drop deprecated OMS prefix from sources
d474552
@vault087
Remove all deprecated OMS prefixes and deprecated Swift version compa…
1e67aa1 
…tibility typedefs
@vault087
Fix Credit Card Scene module settings in Interface Builder
6799944
@vault087
Fix all module settings in Interface Builder
11ab409
@vault087
Removed remaining Objective-C files
85ff921
@vault087
New project ExampleApp was created to test OmiseSDK using Swift Packa…
b5df531 
…ge Manager
@vault087
Removed OmiseSDKObjc target from OmiseSDK's Package.swift
ac7fd19
@vault087
Clean up project tree
cbe78bf
@vault087
Add INTERNAL_TEST flag to Example App to test OmiseSDK internally wit…
290136c 
…hout using SPM
@vault087
Set ExampleApp deplyoment target to iOS 12.0 for Xcode 15
0a1af6d
@vault087
Fix swiftlint issues
c320e65
@vault087
Fixing SonarCloud issues
2e84506
@vault087
Example App uses master branch for OmiseSDK by default
85a9fb4
@vault087
Fix comment typo
35d1bf5
@vault087
Sort Currency and CurrencyCode enums for better readability
eb853a4
@vault087
Merge branch 'develop' into feature/MIT-1520
02d4bd8
@vault087
Resolve conflicts after merging with develop
d1a487f
@vault087
Fix CapabilityOperationFixtureTests.swift swiftlint warnings
115b660
@vault087
Remove deprecated Compatibility files
c09dc1c
@vault087
Merge pull request #230 from omise/feature/MIT-1520
efcd72c 
Dropping Objective-C Support (v5.0.0)
@vault087
Renamed OmiseSDK project file to 'dev'. Remove script for Config.loca…
99c0ec5 
…l.example. Remove Config.local from gitignore
@vault087
Remove force loading OmiseSDK bundle from example app
ad31998
@vault087
Use capabilities in Code mode fixed
e418580
@vault087
Update project name in GitHub action
8c9dec2
@vault087
Merge pull request #252 from omise/fix/UseCapabilitiesInCodeMode
216f13f 
Use capabilities in Code mode fixed
@vault087
Refactor CardBrand and update capabilities parser
34500f5
@vault087 vault087 changed the title Release V5.0.0 (Draft) Release V5.0.0 Mar 20, 2024
aashishgurung
aashishgurung previously approved these changes Mar 21, 2024
View reviewed changes
AnasNaouchi
AnasNaouchi previously approved these changes Mar 21, 2024
View reviewed changes
@vault087 vault087 dismissed stale reviews from AnasNaouchi and aashishgurung via 98243bc March 21, 2024 02:57
aashishgurung
aashishgurung previously approved these changes Mar 21, 2024
View reviewed changes
AnasNaouchi
AnasNaouchi previously approved these changes Mar 21, 2024
View reviewed changes
@vault087 vault087 dismissed stale reviews from AnasNaouchi and aashishgurung via 4fff96b March 22, 2024 05:32
@vault087 vault087 merged commit 59cadd7 into master Apr 4, 2024
4 checks passed
@vault087 vault087 deleted the feature/v5_refactoring branch April 4, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishgurung aashishgurung aashishgurung approved these changes

@AnasNaouchi AnasNaouchi AnasNaouchi approved these changes

@annatotest annatotest Awaiting requested review from annatotest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vault087 @aashishgurung @AnasNaouchi @muthuswamyopn