Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent-base monkey patch breaks HTTPS requests #120

Open
PicturElements opened this issue Feb 16, 2020 · 0 comments
Open

agent-base monkey patch breaks HTTPS requests #120

PicturElements opened this issue Feb 16, 2020 · 0 comments

Comments

@PicturElements
Copy link

Up until version 6.0.0, the agent-base package was patching https.request. As a result, it could completely break requests made with the (url, options, callback) signature, as specified by the core https package. As this patch affects HTTPS requests made globally, unrelated code can be severely affected.

Fix: update to the latest version of https-proxy-agent (5.0.0) to fix this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PicturElements