Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A PHPDoc return value declaration for the \OmiseApiResource::isDestroyed() method is wrong #43

Closed
dmitrii-fediuk opened this issue Nov 13, 2016 · 2 comments
Closed

A PHPDoc return value declaration for the \OmiseApiResource::isDestroyed() method is wrong #43

dmitrii-fediuk opened this issue Nov 13, 2016 · 2 comments
Labels
Status: Resolved

Comments

@dmitrii-fediuk
Copy link

https://github.com/omise/omise-php/blob/v2.5.0/lib/omise/res/OmiseApiResource.php#L258

Should be:

@return bool|null
@guzzilar
Copy link
Contributor

guzzilar commented Dec 1, 2016

@dmitry-fedyuk Thanks 👍 !

Do you wanna submit a PR for that one?
I'm ready to merge that PR 😁

Nam.

@guzzilar guzzilar mentioned this issue Mar 21, 2017
Merged
@guzzilar
Copy link
Contributor

Note, this ticket was solved at PR #57.

Im going to close it now.
Thanks for submitted the ticket!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitrii-fediuk @guzzilar