Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the Docblock at OmiseApiResource::isDestroy() method. #57

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Mar 21, 2017

1. Objective

To correct a return tag (@return) in the OmiseApiResource::isDestroy() method's Docblock.

Related information:
Related issue(s): #43

2. Description of change

  • Change @return OmiseApiResource to @return bool|null

3. Quality assurance

This change wasn't effect to any part of an implementation code.

By the way, the following code will shows bool(true).
Note, you must have at least 1 customer object to test the following code.

$customers = OmiseCustomer::retrieve();
$customer  = OmiseCustomer::retrieve($customers['data'][0]['id']);
$customer->destroy();

var_dump($customer->isDestroyed()); exit;

4. Impact of the change

No impact.

5. Priority of change

Normal.

6. Additional Notes

No.

@guzzilar
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant