Add support for Citi, Maybank (EzyPay), TTB, UOB installments #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpariwat
requested review from
tookaa2,
FhanOmise,
jutinapas,
kan98 and
nimitomise
kan98
reviewed
Oct 26, 2021
| @@ -301,6 +301,12 @@ ul.omise-banks-list { | |||
| border-color: #1e4598; | |||
| } | |||
|
|
|||
| /** Citi **/ | |||
There was a problem hiding this comment.
not sure why we have these comments as the class names are pretty clear 😅 , but let's keep them to be consistent
kan98
approved these changes
Oct 26, 2021
nimitomise
approved these changes
Oct 26, 2021
jutinapas
approved these changes
Oct 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Add support for Citi, Maybank (EzyPay), TTB, UOB installments and make them selectable for customers when enabled by admins.
For Thailand
For Malaysia
2. Description of change
3. Quality assurance
Test charge creation for the aforementioned installments.
4. Impact of the change
Admins will see extra installments if enabled in their Capability.
5. Priority of change
Normal.
6. Additional Notes