Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bank of China Logo for FPX #274

Merged
merged 7 commits into from
May 24, 2022

Conversation

jutinapas
Copy link
Contributor

@jutinapas jutinapas commented May 20, 2022

1. Objective

According to https://www.omise.co/which-banks-in-malaysia-support-fpx, the Bank of China (Malaysia) Berhad is not yet supported in the FPX payment method.

2. Description of change

Add the logo of Bank of China (Malaysia) Berhad to the FPX bank support list.

image

@jutinapas jutinapas self-assigned this May 20, 2022
@jutinapas jutinapas marked this pull request as ready for review May 20, 2022 04:52
Copy link
Contributor

@kan98 kan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a screenshot to the PR showing the new bank in the list? thanks!

@jutinapas jutinapas changed the base branch from master to apm2-695-update-fpx-display May 24, 2022 07:40
@jutinapas jutinapas merged commit 57c5f2d into apm2-695-update-fpx-display May 24, 2022
@new4762 new4762 mentioned this pull request Jun 6, 2022
@aashishgurung aashishgurung deleted the fpx-bank-of-china branch October 18, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants