Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENGA3-1084]: Track the adoption of the embedded form #359

Merged
merged 2 commits into from
Mar 29, 2023
Merged

[ENGA3-1084]: Track the adoption of the embedded form #359

merged 2 commits into from
Mar 29, 2023

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Track the adoption of the embedded form

Jira Ticket: #1084

2. Description of change

Added a new key and value for the embedded form whose value will be either yes or no depending on the embedded form feature flag value.

3. Quality assurance

  • Checkout with credit card and check the metadata value in the Opn dashboard. You should see the newly added key and value.
  • Checkout with a payment method other than credit card. You should not see the newly added key and value.

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 4.29.0

[ENGA3-1084]: Added a data in the metadata of the charge for credit c…
49157f9 
…ard payment to track embedded form adoption.
[ENGA3-1084]: Refactored the prepareChargeData. Changed the key embed…
0533d4f 
…ded_form to secure_form to maintain consistency with the label and other porject.
@aashishgurung aashishgurung merged commit 6c4cd4c into develop Mar 29, 2023
@aashishgurung aashishgurung deleted the feature/ENGA3-1084-tracking-adoption branch August 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kan98 kan98 kan98 approved these changes

@ajzkk ajzkk ajzkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aashishgurung @kan98 @ajzkk