-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENGA3-1134]: Installment minimum amount #365
Merged
aashishgurung
merged 6 commits into
develop
from
feature/ENGA3-1134-installment-minimum-amount
Apr 17, 2023
Merged
[ENGA3-1134]: Installment minimum amount #365
aashishgurung
merged 6 commits into
develop
from
feature/ENGA3-1134-installment-minimum-amount
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from capability API.
…HP instead of passing it.
ajzkk
previously approved these changes
Apr 12, 2023
danfowler
reviewed
Apr 17, 2023
…it in installment form
danfowler
reviewed
Apr 17, 2023
danfowler
reviewed
Apr 17, 2023
danfowler
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Fetch the minimum amount of Installment payment method from live config of the Opn account.
Jira Ticket: #1134
2. Description of change
Updated the Omise PHP to use minimum amount from the capability API instead of pre-defined value. Added a function
getInstallmentMinLimits
inincludes/class-omise-capabilities.php
to get the minimum amount to show it in the checkout page.3. Quality assurance
Updated the
minimum installment amount
value from the Opn configurationEnable Installment payment method in WooCommerce.
Add items to the cart but below the installment amount value you set up on the Opn config.
You should see above screenshot.
Add items to the cart above the installment amount value you set up on the Opn config.
You should see a list of banks.
🔧 Environments: