Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a frontend validation to accept only number between 10-13 and a… #366

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Added a frontend validation to accept only number between 10-13 and an optional + sign in front.

Jira Ticket: #929

2. Description of change

Add a validation in the JS and fixed a bug when checkbox same as billing address was not selected.

3. Quality assurance

Case 1:

  • Adding a string should show Phone number should be a number in Atome

Screenshot 2566-04-10 at 18 18 23

Case 2:

  • Adding no phone number should show Phone number is required in Atome

Screenshot 2566-04-10 at 18 18 35

Case 3

  • Adding a phone number with or without + should redirect to Atome page.

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 5.0.0

assets/javascripts/omise-payment-atome.js Outdated Show resolved Hide resolved
templates/payment/form-atome.php Outdated Show resolved Hide resolved
assets/javascripts/omise-payment-atome.js Outdated Show resolved Hide resolved
assets/javascripts/omise-payment-atome.js Outdated Show resolved Hide resolved
assets/javascripts/omise-payment-atome.js Outdated Show resolved Hide resolved
@aashishgurung aashishgurung merged commit d987ec1 into develop Apr 11, 2023
@danfowler danfowler deleted the feature/ENGA3-929-atome-validation branch April 12, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants