Introduce a new plugin template structure. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This concept introduces a new 'templates' structure that allow user/developer to be able hook or extend into their store design, by having a proper 'templates' folder (relocated from 'includes/templates') and separate an admin page out from normal template. Note: This commit just do relocate files and creating a new structure, those concepts haven't been implemented yet.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This concept introduces a new 'templates' structure that would make user/developer easily to work with in order to hook or extend the Omise template, by having a proper 'templates' folder (relocated from 'includes/templates') and separate an admin pages out from the user template.
2. Description of change
File path changes
3. Quality assurance
🔧 Environments:
✏️ Details:
Tested if you can still access and see these pages.
3.1. ✅ Credit card form at the checkout page.
3.2. ✅ Saved card list panel at the 'my-profile' page.
3.3. ✅ Admin page, Omise dashboard.
3.4. ✅ Admin page, Omise transfer list page.
4. Impact of the change
5. Priority of change
Normal
6. Additional Notes
No.