Fix installment payment when admin manually pay for order #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 3, 2023 14:58
…cart when the payment page is triggered from admin.
danfowler
reviewed
Aug 4, 2023
ajzkk
reviewed
Aug 4, 2023
ajzkk
approved these changes
Aug 4, 2023
danfowler
approved these changes
Aug 4, 2023
Merged
aashishgurung
added a commit
that referenced
this pull request
Aug 9, 2023
* Fixed Japanese translation issue in secure form. * Used locale instead of hardcoded en * Fix installment payment when admin manually pay for order (#388) * [MIT-1562]: Total amount for payment is pulled from order instead of cart when the payment page is triggered from admin. * Fixed the issue with Japanese language Support in the secure form. * Added unit test for installment * Added unit test for installment * Updated test * Fix indentation * Fix the tests after code chagne. * Fix the spelling mistake. * Reverted secure form changes. --------- Co-authored-by: Aashish <aashish@omise.co> * Updated metadata for v5.2.1 --------- Co-authored-by: (AJ) Zin Kyaw Kyaw <108650842+ajzkk@users.noreply.github.com> Co-authored-by: Aashish <aashish@omise.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Fix installment payment when admin manually pay for order.
2. Description of change
Installment payment was not functioning properly when admin manually pay for order because the total amount was 0. This happened because logic was getting the total from the cart. But, cart is not present when admin pay for an order. So, we added a check that will get the total amount from order if the payment page is triggered by admin. If not then we get the total from cart.
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments: