Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QR expires count down for promptpay #408

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Add QR expires count down for promptpay #408

merged 6 commits into from
Oct 17, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Oct 12, 2023 •
edited

1. Objective

Add QR expires count down for promptpay

https://opn-ooo.atlassian.net/browse/MIT-1889

2. Description of change

  • Show QR code expire count down instead of date time.
  • Created get_pending_status function since it does not support to mock constant.
  • Created file_get_contents wrapper class since it does not support to mock global function.
Screenshot 2023-10-12 at 1 44 09 PM

3. Quality assurance

  • Crate payment with promptpay QR and checked count down is correct.
  • And wait for expiration and refresh the page which should be hidden QR code image.

4. Impact of the change

N/A

5. Priority of change

Normal

@ajzkk ajzkk marked this pull request as draft October 12, 2023 07:21
@ajzkk ajzkk force-pushed the promptypay-qr-expires-in-count-down branch from fd52256 to 25f8c76 Compare October 12, 2023 08:18
@ajzkk ajzkk marked this pull request as ready for review October 16, 2023 07:36
aashishgurung
aashishgurung previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@aashishgurung aashishgurung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove file_get_contents from Omise_Payment. Other than that LGTM.

@ajzkk ajzkk merged commit 8722d96 into develop Oct 17, 2023
3 checks passed
@ajzkk ajzkk deleted the promptypay-qr-expires-in-count-down branch October 17, 2023 04:39
@aashishgurung aashishgurung mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnasNaouchi AnasNaouchi AnasNaouchi approved these changes

@aashishgurung aashishgurung aashishgurung left review comments

@danfowler danfowler Awaiting requested review from danfowler

@annatotest annatotest Awaiting requested review from annatotest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajzkk @aashishgurung @AnasNaouchi