Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google fonts other than Poppins #416

Merged
merged 20 commits into from Nov 14, 2023
Merged

Conversation

aashishgurung
Copy link
Contributor

@aashishgurung aashishgurung commented Nov 10, 2023

1. Objective

Support Google fonts other than Poppins

2. Description of change

Add others as an option to font name. This will activate a field where you can specify the Google font that you want to use

🔧 Environments:

  • WooCommerce: v8.2.2
  • WordPress: v6.4.1-alpha-57080
  • PHP version: 8.1

@aashishgurung aashishgurung marked this pull request as ready for review November 13, 2023 02:05
@aashishgurung aashishgurung requested a review from a team as a code owner November 13, 2023 02:05
muthuswamyopn
muthuswamyopn previously approved these changes Nov 13, 2023
AnasNaouchi
AnasNaouchi previously approved these changes Nov 13, 2023
assets/javascripts/card-form-customization.js Outdated Show resolved Hide resolved
assets/javascripts/card-form-customization.js Outdated Show resolved Hide resolved
assets/javascripts/omise-embedded-card.js Outdated Show resolved Hide resolved
assets/javascripts/card-form-customization.js Show resolved Hide resolved
danfowler
danfowler previously approved these changes Nov 13, 2023
@danfowler danfowler self-requested a review November 13, 2023 09:39
@danfowler danfowler self-requested a review November 13, 2023 09:44
@annatotest annatotest self-requested a review November 14, 2023 04:01
annatotest
annatotest previously approved these changes Nov 14, 2023
danfowler
danfowler previously approved these changes Nov 14, 2023
danfowler
danfowler previously approved these changes Nov 14, 2023
@annatotest annatotest self-requested a review November 14, 2023 08:09
@aashishgurung aashishgurung merged commit 839e8bd into develop Nov 14, 2023
3 checks passed
@aashishgurung aashishgurung deleted the support_custom_fonts branch November 14, 2023 08:30
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants