Add transaction request support for omisego-admin
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
mederic-p
previously approved these changes
Nov 5, 2018
T-Dnzt
reviewed
Nov 8, 2018
There was a problem hiding this comment.
I think I noticed @mederic-p switched to network.omisego... instead of co/com. Shouldn't we do the same for Android?
|
@T-Dnzt Yeah, it should be the same. Will change in later PR. |
added 18 commits
November 21, 2018 11:33
ripzery
force-pushed
the
74-add-transaction-request-support
branch
from
fa74d3d
to
7a99f80
Compare
ripzery
changed the base branch from
71-add-login-api-for-omg-client
to
master
mederic-p
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #74
Closes #74
Overview
This PR adds the following APIs support for
omisego-admin:transaction_request.gettransaction_request.createtransaction_request.consumetransaction_consumption.approvetransaction_consumption.rejectChanges
omisego-adminmodule.adminandclientmodule.Implementation Details
Because of the parameters set that used for
create a transaction,create a transaction request, andcreate a transaction consumptionare not the same foradminandclient, this PR separate models that used for the request to those APIs as the following:Create the following models to
adminmodule:TransactionConsumptionParamsTransactionRequestCreateParamsTransactionCreateParamsMove the following models from
coremodule toclientmodule:TransactionConsumptionParamsTransactionRequestCreateParamsTransactionCreateParamsUsage
See README.md in
omisego-admindirectory.Impact
Need to re-import moved-package classes.