Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master v2 (new events) #1794

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Master v2 (new events) #1794

merged 2 commits into from
Dec 10, 2020

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Dec 7, 2020

Overview

This PRs adds new events from contracts v2

@ayrat555 ayrat555 mentioned this pull request Dec 7, 2020
@ayrat555 ayrat555 requested a review from pgebal December 7, 2020 18:14
@ayrat555 ayrat555 changed the base branch from master-v2 to ayrat555/master-to-master-v2 December 7, 2020 18:24
Base automatically changed from ayrat555/master-to-master-v2 to master-v2 December 8, 2020 13:55
Copy link
Contributor

@InoMurko InoMurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is now code in the Aggregator that is not used anymore, since all enrich events are set to false.
for example:

case Keyword.fetch!(event, :enrich) do
        true ->
          {:ok, enriched_data} = rpc.get_call_data(decoded_log.root_chain_txhash)
          enriched_data_decoded = enriched_data |> from_hex |> Abi.decode_function()
          Map.put(decoded_log, :call_data, enriched_data_decoded)

        _ ->
          decoded_log
      end

@ayrat555 ayrat555 merged commit 2fc1067 into master-v2 Dec 10, 2020
@ayrat555 ayrat555 deleted the master-v2----new-events branch December 10, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants