Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Keys detail page #1016

Merged
merged 67 commits into from
Jun 13, 2019
Merged

Keys detail page #1016

merged 67 commits into from
Jun 13, 2019

Conversation

nicholasmueller
Copy link
Contributor

Issue/Task Number: 952

Overview

New pages and design elements in this series ->
https://gallery.io/projects/MCHbtQVoQ2HCZfyN0ITInFtb/files/MCEJu8Y2hyDScdDsDmlI0w7p47sb7jiw25k

Changes

  • Touches a lot of files since I enforced import rules with the linter (absolute/packages first, then relative local)
  • Key detail pages / assigned accounts

From new design:

  • New search bar (rewrote a simpler version of what we already had)
  • New Id component so we can centralise all the long ids we pass around the site
  • 'Generate Admin Key' modal design
  • also changed select dropdown so u can custom render the value for 'assign account' element and bottom border is optional for usage of dropdown inside tables/rows
  • Nav card component for navigation inside detail pages
  • fetcher for account memberships

I didn't include the 'created by' column as per the design. wanted to do it in another pr as this one is already too big

@T-Dnzt
Copy link

T-Dnzt commented May 28, 2019

A few bugs that came out:

Key assign accounts page

bundle.js:9 failed to dispatch action ACCOUNT with error TypeError: Cannot read property 'find' of undefined
    at Object.ACCOUNT/ASSIGN_KEY/SUCCESS (bundle.js:61)
  • I feel we're missing an indication that the box containing "Assigned Accounts" is clickable

Global Key lists

  • The generate admin key from the key list is really confusing right now. I don't think we should have an account in there, because 1. you can't remove it, 2. it actually changes the role from picking a global role to an account role, without changing any label - was this something that was already like that or changed in this PR?

Key listing under account

  • The clicky hand is showing when I hover the row but can't click on it actually.

T-Dnzt
T-Dnzt previously requested changes May 29, 2019
Copy link

@T-Dnzt T-Dnzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a big comment ☝️

@jarindr
Copy link
Contributor

jarindr commented Jun 5, 2019

more bugs !

  • when switching between admin key /client key the ASSIGNED ACCOUNTS columns display incorrectly.

@mederic-p
Copy link
Contributor

I think you changed something on the global key page following Thibault's comment but something broke and I can't create an admin key from there anymore (I get a permission error message).

Also, can we not pluralize this when only 1?
Screen Shot 2019-06-10 at 13 10 42

@mederic-p
Copy link
Contributor

On the keys page of an account:
When toggling the status the Account role will show None until reloading/switching page.

@nicholasmueller
Copy link
Contributor Author

@jarindr @mederic-p everything should be fixed now

@nebali nebali mentioned this pull request Jun 12, 2019
10 tasks
@jarindr jarindr requested a review from T-Dnzt June 12, 2019 15:31
@jarindr jarindr merged commit 3bc2722 into v1.3 Jun 13, 2019
@jarindr jarindr deleted the 952-keys-detail-page branch June 13, 2019 03:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants