Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

User detail page and refactor modal #1049

Merged
merged 4 commits into from
Jun 10, 2019
Merged

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Jun 10, 2019

Issue/Task Number: #252

Overview

This PR includes many things when doing user page, because I need to reuse many parts of the app So I think it is a good time to do a big refactoring.

Changes

  • Add new User detail page.
  • Refactor table for transaction, activity. Since we need to reuse in many pages.
  • Refactor out Create transaction modal so you can open the modal with action.
  • Add env example

Implementation Details

  • Move modal out from components, open with action.

Usage

  • Click on user table row, see the new user detail.

Impact

Deploy as usual after fixing conflicts.

@jarindr jarindr self-assigned this Jun 10, 2019
@jarindr jarindr changed the title attempt to fix broken branch User detail page and refactor modal Jun 10, 2019
@jarindr jarindr closed this Jun 10, 2019
@jarindr jarindr reopened this Jun 10, 2019
@jarindr jarindr merged commit 69f3ef4 into v1.3 Jun 10, 2019
@jarindr jarindr deleted the 948-user-page-refactor-modal branch June 10, 2019 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants