This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Fix internal server error when providing an association as the filter param #1052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #1051
Overview
This PR fixes a specific case of filtering when an association name is given as the filter param without specifying the association's field.
Changes
Implementation Details
Overlay filters could be in the form of:
So when an association is given as a filter param without its dot-notated subfield, e.g.
field: "some_assoc"
instead offield: "some_assoc.id"
, it treats[:id, :name]
as a field type like:uuid
instead of a list of associated subfields, and hence the internal server error.An
is_list(type)
guard is added to catch the association and return: missing_subfield
for further processing by the parser and orchestrator.Usage
Try the request in #1051. Its return should be similar to:
Impact
No changes to the API specs or DB schema.