This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Minor fix transaction consumption confirmation #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
reviewed
Jun 12, 2019
apps/ewallet/lib/ewallet/validators/transaction_consumption_validator.ex
Outdated
Show resolved
Hide resolved
T-Dnzt
suggested changes
Jun 13, 2019
apps/ewallet/lib/ewallet/validators/transaction_consumption_validator.ex
Outdated
Show resolved
Hide resolved
ripzery
force-pushed
the
950-add-endpoint-cancel-transaction-request
branch
from
35a79ae
to
5df6452
Compare
ripzery
force-pushed
the
1053-minor-fix-transaction-consumption-confirmation
branch
2 times, most recently
from
cf75f58
to
9ebdd49
Compare
unnawut
reviewed
Jun 17, 2019
apps/ewallet/test/ewallet/gates/transaction_consumption_confirmer_gate_test.exs
Show resolved
Hide resolved
apps/ewallet/test/ewallet/validators/transaction_consumption_validator_test.exs
Show resolved
Hide resolved
apps/ewallet/test/ewallet/gates/transaction_consumption_confirmer_gate_test.exs
Show resolved
Hide resolved
T-Dnzt
approved these changes
Jun 17, 2019
unnawut
approved these changes
Jun 17, 2019
added 9 commits
June 17, 2019 18:41
ripzery
force-pushed
the
1053-minor-fix-transaction-consumption-confirmation
branch
from
30e7318
to
56cd1fd
Compare
ripzery
changed the base branch from
950-add-endpoint-cancel-transaction-request
to
v1.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #1053
Closes #1053
Overview
This PR allows the transaction consumption with an expired transaction request with
expiration_reason = "expired_transaction_request"to be confirmed