Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Token expiration config for admin #1057

Merged
merged 9 commits into from
Jun 21, 2019
Merged

Token expiration config for admin #1057

merged 9 commits into from
Jun 21, 2019

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Jun 16, 2019

Issue/Task Number: #1042

Overview

Add token expiration config for admin panel.

Changes

  • Add token expiration config for admin panel.

Implementation Details

Describe your changes and implementation choices. More details make PRs easier to review.

Usage

Go to configuration page, try changing token expiry.

Impact

Deploy as usual.

@jarindr jarindr changed the base branch from master to v1.3 June 16, 2019 09:39
@jarindr jarindr self-assigned this Jun 17, 2019
@jarindr jarindr requested a review from T-Dnzt June 17, 2019 13:49
@jarindr jarindr added this to the v1.3 milestone Jun 17, 2019
@mederic-p
Copy link
Contributor

mederic-p commented Jun 18, 2019

I think it'd be nice to redirect the user to the login page when you get any user:auth_token_expired error.
For now, I can continue to navigate (until I refresh the page) in the admin panel but it'll not show any data.

Also it doesn't always show the error toast, it's missing on some pages.

I also found that if you keep navigating between menus on the sidebar after your token is expired, yoou will end up with a complete white page at some point.

@nicholasmueller
Copy link
Contributor

ya a redirect to login will probably be easiest. also we should set a minimum on the token expiry, like 1 minute, because if you set it to 1 second, you've essentially locked yourself out of your account lol

@jarindr
Copy link
Contributor Author

jarindr commented Jun 20, 2019

@mederic-p @nicholasmueller added feature to kick ppl out when token expire.

@mederic-p mederic-p added this to Review in eWallet via automation Jun 21, 2019
@jarindr jarindr merged commit fa537b5 into v1.3 Jun 21, 2019
eWallet automation moved this from Review to Done Jun 21, 2019
@jarindr jarindr deleted the 1042-token-expiration branch June 21, 2019 02:51
@nebali nebali mentioned this pull request Jun 22, 2019
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
eWallet
  
5-Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants