This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it'd be nice to redirect the user to the login page when you get any Also it doesn't always show the error toast, it's missing on some pages. I also found that if you keep navigating between menus on the sidebar after your token is expired, yoou will end up with a complete white page at some point. |
ya a redirect to login will probably be easiest. also we should set a minimum on the token expiry, like 1 minute, because if you set it to 1 second, you've essentially locked yourself out of your account lol |
@mederic-p @nicholasmueller added feature to kick ppl out when token expire. |
mederic-p
approved these changes
Jun 21, 2019
nicholasmueller
approved these changes
Jun 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #1042
Overview
Add token expiration config for admin panel.
Changes
Implementation Details
Describe your changes and implementation choices. More details make PRs easier to review.
Usage
Go to configuration page, try changing token expiry.
Impact
Deploy as usual.