This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Add blockchain_wallet.get
and blockchain_wallet.all
#1072
Merged
mederic-p
merged 28 commits into
master
from
691-management-endpoints-for-blockchain-wallet
Jul 2, 2019
Merged
Add blockchain_wallet.get
and blockchain_wallet.all
#1072
mederic-p
merged 28 commits into
master
from
691-management-endpoints-for-blockchain-wallet
Jul 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
reviewed
Jun 25, 2019
apps/admin_api/lib/admin_api/v1/controllers/blockchain_wallet_controller.ex
Outdated
Show resolved
Hide resolved
apps/admin_api/lib/admin_api/v1/controllers/blockchain_wallet_controller.ex
Outdated
Show resolved
Hide resolved
apps/ewallet/test/ewallet/fetchers/blockchain_balance_fetcher_test.exs
Outdated
Show resolved
Hide resolved
apps/ewallet/test/ewallet/web/blockchain_balance_loader_test.exs
Outdated
Show resolved
Hide resolved
Should Also, |
unnawut
reviewed
Jun 27, 2019
Also this probably needs an update: |
I think it can be updated when the |
unnawut
approved these changes
Jun 28, 2019
mederic-p
approved these changes
Jul 1, 2019
unnawut
approved these changes
Jul 1, 2019
apps/admin_api/lib/admin_api/v1/controllers/blockchain_wallet_controller.ex
Show resolved
Hide resolved
unnawut
approved these changes
Jul 1, 2019
T-Dnzt
approved these changes
Jul 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #691
Closes #691
Overview
This PR adds 2 endpoints for blockchain wallet which are:
blockchain_wallet.get
to get a single wallet by the given addressblockchain_wallet.all
to get all wallets by given pagination paramsUsage
Follows Setup local geth testnet guide then you will need to create a wallet and update tokens'
blockchain_address
:mix seed --sample
iex -S mix
Replace address with your wallet address from the geth setup.
blockchain_address
blockchain_address
Replace
omg_address
with the omg token address from geth (Runomgtoken.address
)/blockchain_wallet.get
and/blockchain_wallet.all
in the Swagger