This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Ethereum transactions logic and endpoints #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Dnzt
force-pushed
the
1060-eth-transactions-logic
branch
from
01dccb4
to
fb80753
Compare
T-Dnzt
changed the title
T-Dnzt
force-pushed
the
1060-eth-transactions-logic
branch
from
83fa752
to
4727c05
Compare
mederic-p
reviewed
Jul 5, 2019
apps/ewallet/test/support/db_case.ex
Outdated
| } | ||
| ) | ||
|
|
||
| %{config_pid: config_pid} | ||
| :ok = Application.put_env(:ewallet, :node_adapter, {:dumb, DumbAdapter}) |
There was a problem hiding this comment.
May be better to put it in the test.exs config?
unnawut
reviewed
Jul 10, 2019
| case Account.get(master_account_id) do | ||
| nil -> | ||
| { | ||
| Map.delete(attrs, "master_account"), | ||
| {:master_account, {:error, prepare_error(master_account_id)}} | ||
| [{:master_account, {:error, prepare_account_error(master_account_id)}} | errors] |
There was a problem hiding this comment.
Should we refactor/move this implementation detail inside e.g. prepare_account_error(errors, :master_account, master_account_id)? Also prepare_hot_wallet_error(errors, :primary_hot_wallet, primary_hot_wallet_address).
apps/admin_api/lib/admin_api/v1/controllers/transaction_controller.ex
Outdated
Show resolved
Hide resolved
apps/eth_blockchain/lib/eth_blockchain/listeners/transaction_listener.ex
Show resolved
Hide resolved
apps/eth_blockchain/lib/eth_blockchain/listeners/transaction_listener.ex
Outdated
Show resolved
Hide resolved
apps/eth_blockchain/lib/eth_blockchain/listeners/transaction_listener.ex
Outdated
Show resolved
Hide resolved
ripzery
reviewed
Jul 10, 2019
| adapter, | ||
| state, | ||
| confirmations_count, | ||
| confirmations_count > (threshold || 10) |
There was a problem hiding this comment.
Can we define a module attribute for the default confirmations threshold (10) somewhere?
There was a problem hiding this comment.
I also wonder isn't it suppose to be >=?
unnawut
reviewed
Jul 10, 2019
apps/eth_blockchain/lib/eth_blockchain/listeners/transaction_listener.ex
Show resolved
Hide resolved
apps/eth_blockchain/test/eth_blockchain/listeners/transaction_listener_test.exs
Show resolved
Hide resolved
apps/eth_blockchain/test/eth_blockchain/listeners/transaction_listener_test.exs
Outdated
Show resolved
Hide resolved
apps/eth_blockchain/test/eth_blockchain/listeners/transaction_listener_test.exs
Show resolved
Hide resolved
unnawut
approved these changes
Jul 11, 2019
apps/eth_blockchain/test/eth_blockchain/listeners/transaction_listener_test.exs
Show resolved
Hide resolved
mederic-p
approved these changes
Jul 11, 2019
|
Merging, the linting issues will be fixed in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #1060
Overview
This PR adds the first blockchain transaction flow, to send funds from the hot wallet directly to an external address. This should actually only be used to get funds out of the hot wallet and into one of the cold wallets used together as the pool of funds the eWallet has access to.
Changes
BlockchainTransactionGateand aTransactionDispatcherGateTransactionGatetoLocalTransactionGateUsage
You will need to go through the blockchain setup that @mederic-p has done in order to have Geth setup properly.
Impact
You will need to run Geth in order to have the blockchain features working (errors aren't currently handled). Tests can be run without it.